Support updates to partial docker compose file#665
Support updates to partial docker compose file#665avargaskun wants to merge 1 commit intogetwud:mainfrom
Conversation
|
This PR also addresses an unrelated issue with splitting a Compose file into multiple files. The code currently expects the For example: services:
my_example:
container_name: my_example
build:
context: ./dockerfiles/my_example
|
|
@HCanber how would that work with WUD? If the image is built on demand as part of deploying the compose file... there's no image to watch for updates... Side note, I moved away from using that as it's fairly trivial to just build images and publish them somewhere. |
PrivatePuffin
left a comment
PrivatePuffin
left a comment
There was a problem hiding this comment.
Technically this can be merged, though we might want to add a testcase as well.
We can safely assume if an image is not present we can just ignore it and go on, instead of hard-error.
You're correct, this comment can be hidden as it adds nothing and doesn't contain a reference that is parseable by WUD |
|
hey guys, any chance of this being merged into main and cutting a new release? |
|
This has been integrated into WUD-CE as of 9.0.0-ce. Thanks for the contribution! |
7 participants
fixes #586
from: #586 (comment)
I'm running into another instance of this issue. I split my compose project into 'modules' and include each module's partial compose file conditionally at the time
docker compose upis called. I create multipledockercomposetriggers, one for each partial compose file that defines a service. The problem is, some of the partial compose files specify overrides for services they depend on, so there are sometimes 'incomplete' service definitions in a given compose yml file.Example:
base/docker-compose.yml (fragment)
portainer/docker-compose.yml (fragment)
The problem is that the code for the Dockercompose trigger iterates the
servicesin my partial file for portainer and finds the 'incomplete' definition forwud. Specifically, it tries to access properties ofservices.wud.imageand fails becauseimageis not defined forwudin this particular file.